search

framed-data / overseer

Overseer is a library for building and running data pipelines in Clojure.
Eclipse Public License 1.0
97 stars 10 forks source link

API: Fix identity function in harnessing #30

Closed andrewberls closed 9 years ago

andrewberls commented 9 years ago

Previously when harnessing missing keys, the identity function was supplied, returning the job it was passed. This is very useful for uniformly harnessing a set of jobs which may or may not define the particular lifecycle being harnessed.

However, identity (of arity 1) is only sufficient for 2/3 cases - pre-process and process. post-process has arity 2 (job res) and we need to use an appropriate identity function in that case.

elliot42 commented 9 years ago

(The code looks good but the test case actually confuses me--is there a simpler explanation or possibly a slightly different phrasing of the test case?)

elliot42 commented 9 years ago

:+1: