search

framed-data / overseer

Overseer is a library for building and running data pipelines in Clojure.
Eclipse Public License 1.0
97 stars 10 forks source link

Use gitbook@2.4.3 #71

Closed AaronO closed 8 years ago

AaronO commented 8 years ago

Hey @andrewberls, following up on our Slack conversation.

gitbook@2.5.0 and above (latest current version is 2.6.4) don't accept structure.summary to be a file that's not in the root folder. (Because it opens a can of worms and can have lots of unexpected/strange side effects that would be even more confusing for users).

We'll improve the error message so it reflects that, and more importantly the 2.7.0 release will add a root option to book.json that you will probably want to use and have set as "root": "doc/guide/" (as soon as the 2.7.0 release is out).

In the meantime locking your gitbook version to 2.4.3 works, so that's exactly what this PR does :)

andrewberls commented 8 years ago

Looks good to me! Thanks so much for following up on this :+1:

AaronO commented 8 years ago

@andrewberls No problem, I'm happy to help :)