search

framesurge / perseus

A state-driven web development framework for Rust with full support for server-side rendering and static generation.
https://framesurge.sh/perseus/en-US
MIT License
2.18k stars 89 forks source link

Latest beta fails with `cargo-clif` #246

Closed arctic-hen7 closed 1 year ago

arctic-hen7 commented 1 year ago

This issue is reporting a bug in the code of Perseus. Details of the scope will be available in issue labels. The author described their issue as follows:

Attempting to build Perseus using the recommended alternative cargo-clif compiler currently fails with the latest version (v0.4.0-beta.12), due to the RUSTFLAGS setting seemingly not being correctly handled, resulting in the required --cfg=engine flag not carrying through, meaning the core fails to compile.

The steps to reproduce this issue are as follows:

Download cargo-clif according to the instructions in the Perseus docs, and then run perseus build --cargo-engine-path cargo-clif, assuming cargo-clif is in your $PATH. This will lead to a series of errors in the perseus package.

A minimum reproducible example is available at <>.

Tribble internal data dHJpYmJsZS1yZXBvcnRlZCxDLWJ1ZyxBLWNsaSxhdXRob3Itd2lsbGluZy10by1pbXBs
arctic-hen7 commented 1 year ago

For now, of course, my recommendation to users affected by this is to use the default compiler instead, or switch back to beta 11 for now.

arctic-hen7 commented 1 year ago

From my testing, this is now resolved in v0.4.0-beta.14, as lockfile generation now correctly passes RUSTFLAGS through. It turned out that this bug could also be replicated with the standard compiler, it just required deleting the existing lockfile. This didn't trigger tests because of the .cargo/config.toml file at the root of the repo, I think.