francois-roseberry / monopoly-js

Javascript implementation of the Monopoly game
36 stars 14 forks source link

Spinner in trade-ui do not show up anymore #25

Open francois-roseberry opened 2 weeks ago

francois-roseberry commented 2 weeks ago

It is there, cause I can click on it, although it is invisible. Must solve this before I can overwrite the previous deployment on github-pages, which dates from a couple years ago and has a spinner that works

francois-roseberry commented 2 weeks ago

It has an aria-hidden attribute and it has no span element with the image, inside the spinner

francois-roseberry commented 2 weeks ago

the aria-hidden attribute is because of the version 1.14 of jquery-ui, I confirmed by looking at the demo on their website. It should not prevent the element from containing an image.

I will look at the source to try to find what is causing the error.

francois-roseberry commented 2 weeks ago

The right images are copies in the dist ... maybe the path to the images is not right ? How does jquery-ui know the images are in .../images/ ?

francois-roseberry commented 2 weeks ago

It is relatives to the CSS of the app (which include jquery-ui), so the images/ path should be ok ...