search

franela / goblin

Minimal and Beautiful Go testing framework
MIT License
884 stars 79 forks source link

Fix regex parsing #83

Closed marcosnils closed 4 years ago

marcosnils commented 4 years ago

Alternative to #79 and fixes #74 cc @sockol

sockol commented 4 years ago

I tried removing that, that didn't break the TestAsync test?

marcosnils commented 4 years ago

Yes, that's why I moved TestAsync to the very beginning, so the way we parse flags doesn't affect the test run.

sockol commented 4 years ago

Got it. That seems to fix the issue so this seems like the less invasive approach