search

frankmullenger / silverstripe-gallery

Image gallery for SilverStripe 3
23 stars 17 forks source link

Compatibility with the FocusPoint module #13

Open pinkp opened 10 years ago

pinkp commented 10 years ago

It does not seem to work with the FocusPoint module: https://github.com/jonom/silverstripe-focuspoint This extends all images to allow them to have a focus point chosen for cropping which is chosen in the edit window of each image. After selecting a point and saving it, it defaults back to the centre of the image. This only happens with the images inside this modules gallery pages.. Do you know how I can allow these changes to be saved within your module? Many thanks

frankmullenger commented 10 years ago

@pinkp I haven't used focus point but would love to know if and how you get it working. From the readme it mentions using $CroppedFocusedImage - maybe you could try that in your template first..

pinkp commented 10 years ago

Hi Frank, FocusPoint is very easy to install you just out the folder in the root and dev/build it there is no other settings apart from in the template as you mention above. I have changed your template in the Gallery Page to use $CroppedFocusedImage and it works. The issue is if I got to "edit" and image in the gallery and choose a new focus point it does not save. After clicking save it simply snaps back to the point it was already on. The only way to get around this I have is to go to Files and choose the point there. This is not very convenient.. So it must be something needs adding / changing to your code to allow the extension to be saved. Any help would be amazing as your Module is the best Gallery out there and this would be an amazingly helpful addition. Thanks

pinkp commented 10 years ago

Hi Frank, did you ever have a chance to look in to this at all? It would be a great addition to your module. It just doesn't save for gallery images.. Many thanks

thezenmonkey commented 10 years ago

From what I can tell the main prblem with using the focus point module is that the ItemEditFrom that the gallery module shows calls the gallery doEdit on save. doEdit only saves changes to the join table and not the actual image item. The focus points are saved on the image table. You'd need to add $form->saveInto($item); into the doEdit or something like that.

pinkp commented 10 years ago

Sounds great! I'm not quite sure how to do that, but hopefully it something Frank can add.

thezenmonkey commented 10 years ago

Take a look at the following pull request if you can't wait for Frank to merge. https://github.com/frankmullenger/silverstripe-gallery/pull/23

jonom commented 9 years ago

Think this can be closed thanks to #23?