search

franzliedke / studio

A workbench for developing Composer packages.
MIT License
1.14k stars 73 forks source link

Commands must return an exit status #102

Closed apfelbox closed 4 years ago

apfelbox commented 4 years ago

Hi,

since Symfony 5 commands must return a status code, see:

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Command/Command.php#L261

So while the composer.json currently allows to install it with Symfony 5, running any command will just crash.

apfelbox commented 4 years ago

The second commit bumps phpspec/phpspec, as the previous version was really old. It also uses a different branch for composer/composer, as their dev-master is now for v2, which doesn't (yet) work with this plugin.

franzliedke commented 4 years ago

Thanks a lot, I appreciate it!!! :heart:

franzliedke commented 4 years ago

I had to downgrade phpspec again by a bit, because the tests were failing in master. (I hadn't configured GitHub Actions properly, so the tests were not run for PRs. :face_with_head_bandage:.)

apfelbox commented 4 years ago

Thank you for merging! @franzliedke

Ah, I did only run them with PHP 7.4, so they were green. 😅 Do you already have an ETA for the next tagged version? Locally I installed it via dev-master#... as 0.14.0 but would be glad to update to a release. 😄