search

frappe / ecommerce_integrations

Ecommerce integrations for ERPNext
https://frappecloud.com/marketplace/apps/ecommerce_integrations
GNU General Public License v3.0
109 stars 144 forks source link

fix: shopify sync issue without customer #301

Closed rohitwaghchaure closed 10 months ago

rohitwaghchaure commented 10 months ago

Without customer getting the below error while syncing sales orders from Shopify to ERPNext

Traceback (most recent call last):
  File "apps/ecommerce_integrations/ecommerce_integrations/shopify/order.py", line 55, in sync_sales_order
    create_order(order, setting)
  File "apps/ecommerce_integrations/ecommerce_integrations/shopify/order.py", line 67, in create_order
    so = create_sales_order(order, setting, company)
  File "apps/ecommerce_integrations/ecommerce_integrations/shopify/order.py", line 78, in create_sales_order
    if customer_id := shopify_order.get("customer", {}).get("id"):
AttributeError: 'NoneType' object has no attribute 'get'
github-actions[bot] commented 9 months ago

:tada: This PR is included in version 1.20.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: