search

frappe / ecommerce_integrations

Ecommerce integrations for ERPNext
https://frappecloud.com/marketplace/apps/ecommerce_integrations
GNU General Public License v3.0
109 stars 144 forks source link

Issue getting products from Shopify. #309

Open shadmeoli opened 8 months ago

shadmeoli commented 8 months ago

I am getting an issue getting product from shopify.

App Versions

{
    "builder": "1.4.0",
    "doppio": "0.0.1",
    "ecommerce_integrations": "1.17.0",
    "erpnext": "15.13.0",
    "frappe": "15.13.0",
    "hrms": "16.0.0-dev",
    "raven": "1.3.2",
    "studio_dashboard": "0.0.1",
    "vendor": "0.0.1"
}

Route

shopify-import-products

Traceback

Traceback (most recent call last):
  File "apps/frappe/frappe/app.py", line 110, in application
    response = frappe.api.handle(request)
  File "apps/frappe/frappe/api/__init__.py", line 49, in handle
    data = endpoint(**arguments)
  File "apps/frappe/frappe/api/v1.py", line 36, in handle_rpc_call
    return frappe.handler.handle()
  File "apps/frappe/frappe/handler.py", line 49, in handle
    data = execute_cmd(cmd)
  File "apps/frappe/frappe/handler.py", line 85, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "apps/frappe/frappe/__init__.py", line 1682, in call
    return fn(*args, **newargs)
  File "apps/frappe/frappe/utils/typing_validations.py", line 31, in wrapper
    return func(*args, **kwargs)
  File "apps/ecommerce_integrations/ecommerce_integrations/shopify/page/shopify_import_products/shopify_import_products.py", line 19, in get_shopify_products
    shopify_products = fetch_all_products(from_)
  File "apps/ecommerce_integrations/ecommerce_integrations/shopify/page/shopify_import_products/shopify_import_products.py", line 30, in fetch_all_products
    for product in collection:
TypeError: 'NoneType' object is not iterable

Request Data

{
    "type": "POST",
    "args": {
        "from_": null
    },
    "headers": {},
    "error_handlers": {},
    "url": "/api/method/ecommerce_integrations.shopify.page.shopify_import_products.shopify_import_products.get_shopify_products",
    "request_id": null
}

Response Data

{
    "exception": "TypeError: 'NoneType' object is not iterable",
    "exc_type": "TypeError",
    "_exc_source": "ecommerce_integrations (app)"
}

When I use the credentials I used to connect to shopify separately I am getting the products.