search

frappe / lms

Easy to Use, 100% Open Source Learning Management System
https://frappe.io/learning
GNU Affero General Public License v3.0
1.07k stars 489 forks source link

fix(overrides): call parent's `after_insert()` as well #994

Closed akhilnarang closed 3 months ago

akhilnarang commented 3 months ago

Support ticket #20855, #20873

User's notifications settings get created in User after_insert hook, which isn't called in this case

cypress[bot] commented 3 months ago

lms    Run #653

Run Properties:  status check passed Passed #653  •  git commit 1cb0f110c7 ℹ️: Merge 3c9059025b693d413647f35307754bd815629a03 into 4b0413720b044c2ee8522145e459...
Project lms
Branch Review fix-user-creation
Run status status check passed Passed #653
Run duration 00m 33s
Commit git commit 1cb0f110c7 ℹ️: Merge 3c9059025b693d413647f35307754bd815629a03 into 4b0413720b044c2ee8522145e459...
Committer Akhil Narang
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎
frappe-pr-bot commented 2 months ago

:tada: This PR is included in version 2.4.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: