frappe / print_designer

Visual print designer for Frappe / ERPNext
GNU Affero General Public License v3.0
213 stars 116 forks source link

Item name and description in table are not translatable when switch print language. #338

Open letsfkccp opened 1 month ago

letsfkccp commented 1 month ago

Item name and description in table are not translatable when switch print language. This is VERY IMPORTANT for international companies. Please fix it, thank you.

ablashek commented 1 month ago

Actually, i tried this and it works but it's buggy. So in my testing this is what worked (translation) and didn't.

Works: Table Headers. Static Text on any page that isn't the first page.

Doesn't Work: Header Text. Labels that are integrated to a Dynamic Field. Static Text on first page.

Hope this helps figure out where the problem lies.

maharshivpatel commented 1 month ago

Header Text.

Print Header or header in table ?

Labels that are integrated to a Dynamic Field.

Labels have : that is why they are not translated remove that and it will be translated.

Static Text on first page.

That seems unlikely data is processed same way for all pages maybe there is some other variable that is causing it.

Thank you

ablashek commented 3 weeks ago

Thanks @maharshivpatel for the calrification. Yes that makes sense to remove the ":" in order to translate. By Header text i mean the actual header, and with your suggestion to remove the ":" the headers translate correctly.

That seems unlikely data is processed same way for all pages maybe there is some other variable that is causing it.

First page, you can see header labels are being translated. but the static text "Design" isn't. This is also translated in the system. image Second page, you can see header labels are being translated. but the static text "Bill of Materials" is. image

Suggestions: