search

frdedynamics / find_the_duck

🐤 A social game. Have you found the duck? Write your name and hide it again for the next person!
https://frdedynamics.github.io/find_the_duck/
ISC License
2 stars 1 forks source link

Instagram and youtube icons missing #20

Open MOJOliciousFTW opened 2 weeks ago

MOJOliciousFTW commented 2 weeks ago

Describe the bug Links don't look right.

To Reproduce Steps to reproduce the behavior:

  1. Open github page on v0.0.2
  2. Scroll to bottom
  3. See error

Expected behavior Links showing instagram and youtube icons

Screenshots image

Desktop (please complete the following information):

Additional context replacing https://github.com/frdedynamics/find_the_duck/issues/18 using new issue template

MOJOliciousFTW commented 2 weeks ago

looks like the links are available https://github.com/frdedynamics/find_the_duck/blob/ac113dbf978aab3bbf63057d1c922756803dcf7d/_config.yml#L26-L31 and code is set up to find icons in /assets/img/icons/ e.g. https://github.com/frdedynamics/find_the_duck/blob/ac113dbf978aab3bbf63057d1c922756803dcf7d/_includes/footer.html#L11

maybe just add instagram.png and youtube.png in https://github.com/frdedynamics/find_the_duck/tree/master/assets/img/icons ? I don't see them there image

MOJOliciousFTW commented 2 weeks ago

@swampbear what do you think?

swampbear commented 2 weeks ago

Missing pngs is my shout

swampbear commented 2 weeks ago

Seems like them missing originates from the original forked repository, where the creator does not personally have these medias. Looking for icons that could fit into the design