search

fredemmott / StreamDeck-CPPSDK

A fork of Elgato's C++ StreamDeck SDK, focussing on reusability
MIT License
44 stars 10 forks source link

Use an `std::filesystem` polyfill like that for `std::fmt` #10

Closed quentinmit closed 2 years ago

quentinmit commented 2 years ago

This restores support for macOS 10.14 (and probably earlier, but I can only test 10.14).

This uses ghc_filesystem, which is a single-header polyfill for std::filesystem.

fredemmott commented 2 years ago

Could you rebase on top of https://github.com/fredemmott/StreamDeck-CPPSDK/tree/test_macos_10_14 please?

While ARM64 macs require MacOS 11, their SDKs still include the version checks needed, so the target version can be set unconditionally.

quentinmit commented 2 years ago

Could you rebase on top of https://github.com/fredemmott/StreamDeck-CPPSDK/tree/test_macos_10_14 please?

Done, I force-pushed here after verifying it still builds for me on macOS 10.14.

It looks like it fails to build on your x86_64 CI, unrelated to the changes in this PR:

CMake Warning:
  Ignoring extra path from command line:

   ".14"
fredemmott commented 2 years ago

Sorry, could you rebase on that branch again please? https://github.com/fredemmott/StreamDeck-CPPSDK/commit/4f0e807e4b2a5856d9bbf688104a23ca38c32128 appears to fix that warning, and probably the likely-related error later when attempting to link; it seems that it's trying to link for 10.0 with libstdc++ instead of libc++

quentinmit commented 2 years ago

Sorry, could you rebase on that branch again please? 4f0e807 appears to fix that warning, and probably the likely-related error later when attempting to link; it seems that it's trying to link for 10.0 with libstdc++ instead of libc++

Rebased, confirmed it still builds on 10.14 for me, and force-pushed my branch.

(Though, again, Elgato officially supports back to 10.11, so you probably should see if it can build that far back.)

fredemmott commented 2 years ago

Thanks; let's get this working on 10.14 first, then check if targeting 10.11 works.

Just to be clear: I make all of this for my personal use, and share in case others find it useful; if it's relatively little work on my end to make it more useful for others, I'm fine with that (and I greatly appreciate this pull request :) ) but I'm not going to set myself a goal of keeping compatibility with older versions - especially when they're no longer supported by Apple, even if they are by Elgato. I'm happy to add the check to CI, though that is as much for "announce if this breaks" as "stop it breaking".

fredemmott commented 2 years ago

That said; thanks again - I'll tag a new release as soon as I'm able to check the actual plugins are fine with this.