search

fredleblanc / roundabout

A 3D Turntable jQuery Plugin.
645 stars 203 forks source link

with jQueryUI animation broken again #87

Open WLL70 opened 11 years ago

WLL70 commented 11 years ago

if you take your sample demo page

http://fredhq.com/projects/roundabout/demos/standard

and add

http://code.jquery.com/ui/1.9.2/jquery-ui.js

to the page and BOOM doesn't rotate any longer.

You are using jQuery Roundabout - v2.1.1 in your demo so i tried both that and your latest v2.4.2 still no dice.

PS: Great plugin

mschel commented 11 years ago

check this issue - worked for me https://github.com/fredhq/roundabout/issues/72

kwilsbach commented 11 years ago

Seeing the same issue with 1.10.1 jquery ui. removing the ui library results in the roundabout working

kwilsbach commented 11 years ago

Line 693 reads:

if (methods.compareVersions.apply(null, [$().jquery, "1.7.2"]) >= 0 && !($.easing["easeOutBack"])) {

if you change this to

if (true) {

it works just fine.

I don't think there is a need for the compareVersions function any more, perhaps a specific "if version is(not) ..*"

jonathanjto commented 11 years ago

Thanks Kwilsbach, this is working perfectly fine for me!

drdeteck commented 11 years ago

Thanks kwilsbach for the fix !

peterbrowse commented 11 years ago

Absolute life saver Kwilsbach, this issue pretty much blows the otherwise awesome plugin up. Can confirm the suggested fix by Kwilsbach, above works perfectly!

kReEsTaL commented 11 years ago

Great, thank you for the fix!

RobCherry commented 11 years ago

+1 on either removing this check, or improving it to work w/ the latest jquery + jquery ui libraries.

kaanozcan commented 11 years ago

using UI 1.10.3 not working for me ...

steno-baz commented 10 years ago

I changed d.compareVersions.apply(null,[a().jquery,"1.7.2"])>=0&&!a.easing["easeOutBack"] with true and all works fine!

I noticed if you charge first jQuery UI than jQuery works the same (but obviously other javascript works bad)

http://code.jquery.com/jquery-1.10.2.min.js http://code.jquery.com/ui/1.10.3/jquery-ui.js jQuery Roundabout - v2.4.2