freeCodeCamp / 100DaysOfCode-twitter-bot

Twitter bot for #100DaysOfCode
https://twitter.com/_100DaysOfCode
BSD 3-Clause "New" or "Revised" License
285 stars 110 forks source link

added a basic check that will congratulate users on their first day o… #8

Closed jamie-wk closed 7 years ago

jamie-wk commented 7 years ago

…f #5

Additionally set up a new Twit stream that checks for new tweets using "#100DaysOfCode"

jamie-wk commented 7 years ago

Added a function to check for the last days

amandeepmittal commented 7 years ago

@king0120 thank you, let me take a look at it. I hope nothing breaks. One suggestion, for future, please do not change the name of variables that already exists since it will break the code coming in other PRs.

amandeepmittal commented 7 years ago

@king0120 All good, but there's one issue. When the bot is running, can you change the way it checks for the number 1, 10 & 100 because if someone tweets Day 1 or if someone tweets Day 100 only checkIfFirstDay function runs which consists Day 1, however for Day 100 the checkIfLastDay function should run & for Day 10 nothing should be done. See these: When a user tweets Day 100 Bot could not recognise the Day100

For the time being I am merging your request, but I am looking forward to a way out.