search

freechipsproject / chisel-bootcamp

Generator Bootcamp Material: Learn Chisel the Right Way
Apache License 2.0
981 stars 278 forks source link

fix(load-ivy.sc): remove redundant space created by `generateVisualizations` #112

Closed fky2015 closed 2 years ago

fky2015 commented 4 years ago

The following code create extra leading space in string.

https://github.com/freechipsproject/chisel-bootcamp/blob/ff68b6671e3c63c7d23d98a03b5bc1ad38eb733c/source/load-ivy.sc#L163 https://github.com/freechipsproject/chisel-bootcamp/blob/ff68b6671e3c63c7d23d98a03b5bc1ad38eb733c/source/load-ivy.sc#L166

Jupyterlab currently will wrongly encode the leading and trailing space to %20, so the image won't display as expected.

So, maybe just remove the space will help.