Open cfm opened 1 day ago
Nice catch. Is this just applicable to 416 or could this be literally any error if e.g. the server returns a 504?
Ideally this would've been a type error caught by mypy...
Yes, you're right: any retry-level error fails this way, and we don't handle HTTP 416
anywhere.
I was going to ask you about mocking Popen.stdin
for the purpose of mangling a Range
header to get a real HTTP 416
cassette, but I think I'll give pytest-subprocess a try first.
Description
API._streaming_download()
chokes on HTTP416
Range Not Satisfiable
errors, because the JSON error object may be received in the first chunk of any request, including any retry, not only at the beginning of the accumulated response.Steps to Reproduce
Expected Behavior
The SDK handles the error gracefully.
Actual Behavior