Closed dependabot[bot] closed 6 months ago
@TheCleric, I guess your mypy integration is working! Any chance you'd be interested/willing/able to tweak this PR to make it work? I totally get if you want to stick with more fun stuff though and not the latest dep upgrade!!!
@TheCleric, I guess your mypy integration is working! Any chance you'd be interested/willing/able to tweak this PR to make it work? I totally get if you want to stick with more fun stuff though and not the latest dep upgrade!!!
I'm happy to take a look.
@dependabot rebase
Sorry, only users with push access can use that command.
@mlissner I think the issue is because we would need to update to django 5 to update the stubs to 5. (Technically python >= 3.10, django-stubs >= 5.0.0 has django 5.0.6 as a dependency).
And that's probably a bigger decision than you want me making. 😆
@dependabot rebase
Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate
.
Hm, we've got django 5.0.6 as of now. We were on a hash release because django 5.0.4 was bad, but I think we're good now and lint is still unhappy, I'm sorry to say.
@dependabot rebase
@mlissner I suspect the outdated version of mypy we're using might be causing the issue. Upgrading to the latest version could potentially resolve it.
@mlissner We can merge it now :shipit: 👍
Nice one! My gut reaction was that this is annoying and our new mypy check is causing trouble, but I think the point is that it actually caught this before it was even more annoying — so great!
Bumps the stub-packages group with 1 update: django-stubs.
Updates
django-stubs
from 4.2.0 to 5.0.0Commits
68b199e
Version 5.0.0 release (django-stubs, django-stubs-ext) (#2087)64a3aac
Remove incorrectReversible
base class fromQuerySet
(#2094)e5f2159
[pre-commit.ci] pre-commit autoupdate (#2092)35fdd20
Bump pytest from 8.1.1 to 8.2.0 (#2091)6f7a19c
Bump black from 24.4.1 to 24.4.2 (#2086)5ef36c5
Add path signature for async views. (#2085)3fe74d8
Bump black from 24.4.0 to 24.4.1 (#2084)0756d06
Bump mypy from 1.9.0 to 1.10.0 (#2083)1546e5c
[pre-commit.ci] pre-commit autoupdate (#2082)11a7f54
5.0: Updatedjango.contrib.postgres
(#2078)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show