search

freemint / m68k-atari-mint-gcc

Fork of GNU's gcc with support for the m68k-atari-mint target
https://github.com/freemint/m68k-atari-mint-gcc/wiki
Other
26 stars 7 forks source link

detect sha512 command #5

Closed miniupnp closed 5 years ago

miniupnp commented 7 years ago

So it works with sha512sum under linux, but also with shasum -a 512 under macOS or FreeBSD.

miniupnp commented 5 years ago

ping !

mikrosk commented 5 years ago

Shouldn't this go to upstream?

miniupnp commented 5 years ago

hum https://github.com/freemint/m68k-atari-mint-gcc/commit/61f5892106d384c6a4c07bb9677feba202ed7dab

mikrosk commented 5 years ago

Personally, I'm not in favour to "pollute" gcc sources with custom changes, regardless of their usefulness. I'd like to maintain strict FreeMiNT-related commits only and everything else patch before the building process, for instance in my https://github.com/mikrosk/m68k-atari-mint-build.

What do you think, @vinriviere ?

vinriviere commented 5 years ago

In my build scripts, I often patch some files with sed, because I'm too lazy to create a patch file, and sometimes it wouldn't work at all. Here, this is a very small patch. Of course such changes should go upstream, but when upstream branch has become obsolete, that's no more an option. Generally, when official fixes exist in official version, I try to get them, instead of inventing new ones. I don't know how this issue has been fixed in official GCC. As this patch enables building the cross-tools on FreeBSD and MacOS (he latter being a major platform), I would be tempted to accept it.

mikrosk commented 5 years ago

Ok then, merged. @miniupnp thanks for your contribution and sorry for the delay. :-/