search

freezy / dmd-extensions

A toolbox for virtual pinball dot matrix displays.
GNU General Public License v2.0
120 stars 52 forks source link

Close serial connection for ZeDMD on Dispose(), #475

Closed mkalkbrenner closed 1 month ago

mkalkbrenner commented 1 month ago

closes https://github.com/freezy/dmd-extensions/issues/474

freezy commented 1 month ago

477 fixes the multi disposal. You should open the connection on Init() and close it on Dispose(). Does that make this PR obsolete?

mkalkbrenner commented 1 month ago

477 fixes the multi disposal. You should open the connection on Init() and close it on Dispose(). Does that make this PR obsolete?

No, at the moment we don't close the connection on Dispose(). So the PR should be required.

The downside is that you can't open multiple subsequent tables in VPX anymore but need to close VPX after each table.

freezy commented 1 month ago

The downside is that you can't open multiple subsequent tables in VPX anymore but need to close VPX after each table.

What's the upside, then? ;)

mkalkbrenner commented 1 month ago

If you use a frontend that uses dmdext to show something on the DMD, the connection needs to be closed before VPX gets started. That's how the other DMDs behave as well.