search

freifunk-berlin / firmware

DEPRECATED: Build system for Berlin firmware. Please user the pinned falter-repos instead
https://berlin.freifunk.net
GNU General Public License v3.0
74 stars 34 forks source link

freifunk-berlin-generic: violating PKG_VERSION? #815

Closed PolynomialDivision closed 4 years ago

PolynomialDivision commented 4 years ago

I think setting the PKG_VERSION as commit version of the last commit from the feed, is violating the OpenWrt rules that say:

PKG_VERSION - The upstream version number that we're downloading https://openwrt.org/docs/guide-developer/packages

Actually, there is no real upstream that contains the code. It is more like, we should set the PKG_VERSION:=1 and increase the PKG_RELEASE. Seems also weird. :S https://github.com/freifunk-berlin/firmware-packages/blob/master/freifunk-berlin-generic.mk#L18-L33

SvenRoederer commented 4 years ago

Our definitions copy a lot from the way done in the LuCI-feed,

all this ends up in the same package-definition that we use: https://downloads.openwrt.org/snapshots/packages/x86_64/luci/

So, I'm OK with doing it this way.

SvenRoederer commented 4 years ago

Also see the 2nd paragraph of the PR description of https://github.com/freifunk-berlin/firmware-packages/pull/188. Merge-conflicts have been most often caused by Version-bumps or version-bumps have not been done at all.