search

freifunk-berlin / firmware

DEPRECATED: Build system for Berlin firmware. Please user the pinned falter-repos instead
https://berlin.freifunk.net
GNU General Public License v3.0
74 stars 34 forks source link

GHA/build-fw: replace deprecated 'set-env' with Environment Files #843

Closed SvenRoederer closed 4 years ago

SvenRoederer commented 4 years ago

looking at github actions logs, there are (security vulnerability) warnings:

The set-env command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

according to kubernetes/minikube#9541 running the following command to fix it:

find . -type f -name "*.yml" -print0 | xargs -0 sed -i -r 's/echo "::set-env name=(.*)::(.*)"/echo "\1=\2" >> $GITHUB_ENV/g'"

The warnings have become errors recently, so the build fails and the fix need to be implemented. Tested this in my personal repo before and it seems fine.