Night mode gone since v12.4.0

1977er commented 10 months ago

Expected Behavior

In v12.3.0 the config (see below) kicks in the dark mode. Black background, inverted textcolors etc.

Current Behavior

Since v12.4.0 this does not work anymore. The normal light mode css stuff is used.

Steps to Reproduce

My config looks like this:

{
    "mapLayers": [
      {
        "config": {
          "mode": "night",

use mode: night in one of your mapLayers
reload the website and switch to the given mapLayer

Context

Your Environment

Version used: v12.4.0
Browser Name and version: LibreWolf v120.0-1
Operating System and version (desktop or mobile): macOS 14.2.1
Link to your project: https://hannover.freifunk.net/friedhof/ (irrelevant, since I reverted back to v12.3.0

Screenshots

maurerle commented 3 months ago

@MyIgel @weeman1337 could you have a look at this please? :)

maurerle commented 3 months ago

One could also add a watch to window.matchMedia("(prefers-color-scheme: dark)"); when fixing this, so that one can have mode: auto in the config as well

genofire commented 5 days ago

Was removed here:

https://github.com/freifunk/meshviewer/commit/860cdd9acf4738236b0e5a515c3c4555fd9a9ffe#diff-0eb547304658805aad788d320f10bf1f292797b5e6d745a3bf617584da017051L28

i believe a window.matchMedia("(prefers-color-scheme: dark)") should switch the layer to a mode with night ...

freifunk / meshviewer