frengor / UltimateAdvancementAPI

A powerful API to create custom advancements for your Minecraft server.
https://modrinth.com/plugin/ultimateadvancementapi
GNU General Public License v3.0
116 stars 13 forks source link

Missing background texture #93

Open Karltroid opened 1 month ago

Karltroid commented 1 month ago

In 1.21.5 Mojang changed the background texture path to just be the block name instead of textures/block.png. Our server runs on 1.20.4 and works great but now for 1.21.5 players they see this:

Image

Not sure if this is possible to give different client versions the right texture path?

EscanorTargaryen commented 1 month ago

We fixed this for the new release. https://github.com/frengor/UltimateAdvancementAPI/commit/ab37f88f30808875fe885a9048905d3353bf9e14 Could you give me some examples of your paths? Are there errors in the console?

Karltroid commented 1 month ago

RootAdvancement taking_inventory = new RootAdvancement(beta_achievements, taking_inventoryKey.getKey(), new AdvancementDisplay(Material.BOOK, "Taking Inventory", AdvancementFrameType.TASK, true, false, adapterbeta_achievements.getX(taking_inventoryKey), adapterbeta_achievements.getY(taking_inventoryKey), "§7Press 'E' to open your inventory."), "textures/block/deepslate.png", 1);

using 2.5.1 plugin and api, I dont see any errors and looks the same whether I use "textures/block/deepslate.png" or just "deepslate"

EscanorTargaryen commented 1 month ago

I just tested on 1.21.5 with the api and everything seems to be going correctly, are you shading the UltimateAdvancementAPI? What server are you using (spigot, paper...)? Do you have Viaversion or ViaBackwards that can edit packets?

Karltroid commented 1 month ago

I am using paper/purpur and yes using viaversion and backwards. server is running on 1.20.4, texture is missing just in 1.21.5

EscanorTargaryen commented 1 month ago

I just tried to reproduce the problem but couldn't do it, and without doing it I can't give you much help. However, have you tried updating Viaversion/ViaBackwards/purpur to the last version?