search

frequenz-floss / frequenz-api-weather

gRPC+protobuf specification and Python bindings for the Frequenz Weather API
MIT License
0 stars 8 forks source link

Create a configuration for the client #96

Closed david-natingga-frequenz closed 5 months ago

david-natingga-frequenz commented 5 months ago

What's needed?

The client should have a TOML configuration that should include the following fields:

Proposed solution

No response

Use cases

No response

Alternatives and workarounds

No response

Additional context

No response

shsms commented 5 months ago

No, that would make it hard for users of the client. Only apps should have config files and the clients should define all configurable parameters as arguments that apps can override.

david-natingga-frequenz commented 5 months ago

No, that would make it hard for users of the client. Only apps should have config files and the clients should define all configurable parameters as arguments that apps can override.

@shsms Then would about @cwasicki 's comment here?: https://github.com/frequenz-floss/frequenz-api-weather/pull/89#discussion_r1556216728

david-natingga-frequenz commented 5 months ago

We do not need this anymore.