search

frerich / clcache

A compiler cache for MSVC, much like ccache for gcc
Other
324 stars 83 forks source link

Introduce memoization to getFileHash #240

Closed frerich closed 8 years ago

frerich commented 8 years ago

Analysis of profile reports indicates that a large proportion of the time is spent in getFileHash(), and chances are that this is because getFileHash() is called repeatedly for the same files. Let's test that theory by introducing a cache.

codecov-io commented 8 years ago

Current coverage is 88.88% (diff: 100%)

Merging #240 into master will increase coverage by 0.02%

@@             master       #240   diff @@
==========================================
  Files             1          1          
  Lines           997        999     +2   
  Methods           0          0          
  Messages          0          0          
  Branches        158        158          
==========================================
+ Hits            886        888     +2   
  Misses           83         83          
  Partials         28         28

Powered by Codecov. Last update 718c651...249da4e

frerich commented 8 years ago

This didn't really help with anything, certainly not the suboptimal performance with warm caches reported in #239, so closing this.