codecov-io
commented
6 years ago Codecov Report
Merging #319 into master will decrease coverage by
0.85%. The diff coverage is68.51%.
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
- Coverage 88.93% 88.07% -0.86%
==========================================
Files 4 4
Lines 1301 1350 +49
Branches 195 207 +12
==========================================
+ Hits 1157 1189 +32
- Misses 106 117 +11
- Partials 38 44 +6| Flag | Coverage Δ | |
|---|---|---|
| #integrationtests_memcached | 66.54% <37.03%> (-1.08%) |
:arrow_down: |
| #unittests | 85.11% <68.51%> (-0.75%) |
:arrow_down: |
| Impacted Files | Coverage Δ | |
|---|---|---|
| clcache/__main__.py | 89.81% <68.51%> (-1.07%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update cae73d8...87f41b5. Read the comment docs.
izmmisha
pthom
frerich
Cascades
danix800
How msbuild+tracker works: Tracker injecting it's dll to cl process and intercepting file/process/thread related functions, if child process created it also would be prepared for tracking. Here is example of output when TRACKER_TRACE=1 environ set:
After process exits it dump collected info into tlog files, output file names depends on process name, thread. So parent process (CL) would have CL.{read,write}.{1,2,3,4,...}.tlog, it's child would have different name, it depends on process name, if it is CL then tracker will add PID to filename CL.{CHILDPID}.{read,write}.{1,2,3,4,...}.tlog, but if process name is differs from parent (PYTHON for example) then it would create filename CL-PYTHON.{read,write}.{1,2,3,4,...}.tlog. This is important for next step. msbuild after tracker stop inspecting output files and create only two files cl.read.1.tlog and cl.write.1.tlog, it looking only into cl.{read,write}.1.tlog (for single instance CL) and cl.*.{read,write}.1.tlog (for multiple CL when /MP used).
To make tracker compatible clcache it is necessary that clcache process name and it's childs must have name CL. PyInstaller generated executable works fine (CL.{PID}.{PID}.read.1.tlog would be generated), but clcache.exe from python/scripts/ folder isn't compatible, because it's child process name is PYTHON (CL-PYTHON-CL.read.1.tlog would be generated) and this file ignored by msbuild.
Another thing is /MP, currently clcache using thread pool, and it produce cl.*.read.{2,3,4,5,6..}.tlog files, it is necessary to use process pool.
How to avoid STATS.TXT tracking: As mentioned before msbuild inspecting only cl..read.1.tlog, so it is expecting reads from main thread, and doesn't looking into cl..read.2.tlog. So to avoid STATS.TXT reading to be tracked we can move it to dedicated thread and cl.*.read.2.tlog file.
Also manifest reading should be untrackable because if header files changed then new record would be added to same manifest file.
The changes contains detecting of tracker by TRACKER_ENABLED environ variable, if it present then it will use process pool as executor and will read stats.txt and manifest files from dedicated thread. But if tracker is not detected then clcache will work as before.