search

frictionlessdata / dpm-js

[DEPRECATED] Please use https://datahub.io/docs/features/data-cli
109 stars 18 forks source link

Move Inline Data Example Into Repository #51

Closed waylonflinn closed 8 years ago

waylonflinn commented 8 years ago

This adds the recently added test data for inline data elements to the test/fixtures directory.

There's a hidden catch-22 here. The tests won't pass for this PR, until after it's merged. I've done what I can to ensure that they'll work after the merge, but we should stay vigilant shortly after merging to ensure it works.

rufuspollock commented 8 years ago

@danfowler could you code review this?

danfowler commented 8 years ago

Can do.

waylonflinn commented 8 years ago

@danfowler a bit of history: this builds on PR #50

Please ignore this comment, if that was obvious.

rufuspollock commented 8 years ago

@waylonflinn perfect - thank-you! Merging now.

/cc @danfowler i've now managed to review this so no worries 😄