search

friendsofgo / killgrave

Simple way to generate mock servers written in Go
https://friendsofgo.github.io/killgrave/
MIT License
523 stars 100 forks source link

Added strict slash configurable #91

Closed martin-dos-santos closed 3 years ago

aperezg commented 3 years ago

Amazing!

Two thing, be careful we're working with branches for milestone, so to add this you will need to go from v0.4.1 not from master, the other thing is that for now I wouldn't do it to add configuration, I prefer for now put this as true always with a specific const strictSlash, because I think that is not necessary have this kind of configuration on the mock server.

Thanks a lot!

martin-dos-santos commented 3 years ago

Amazing!

Two thing, be careful we're working with branches for milestone, so to add this you will need to go from v0.4.1 not from master, the other thing is that for now I wouldn't do it to add configuration, I prefer for now put this as true always with a specific const strictSlash, because I think that is not necessary have this kind of configuration on the mock server.

Thanks a lot!

Thanks for your review, I've a new PR which includes what you commented.