search

fritzing / fritzing-app

Fritzing desktop application
http://fritzing.org
Other
3.97k stars 826 forks source link

generate ground fill unit should merge results into one svg #2615

Closed davidperrenoud closed 8 months ago

davidperrenoud commented 10 years ago

From irasc...@gmail.com on June 10, 2013 06:24:33

generate ground fill unit seems to correctly generate a bunch of svgs, but only uses the first one. The svgs should be merged to create a single combined svg.

Original issue: http://code.google.com/p/fritzing/issues/detail?id=2617

failiz commented 8 months ago

Still relevant after the improvements in Fritzing 1.0.2?

KjellMorgenstern commented 8 months ago

I think the mechanism is still the same. The method makeCopperFillFromPolygon (called from generateGroundPlaneUnit , not "generate ground fill unit") still creates an SVG for each polygon.

PCBSketchWidget::generateCopperFillUnit (again, there is no "Generate Ground Fill Unit") returns gpg.newSVGs()[0] , so only the first SVG .

However, in PCBSketchWidget::groundFill , you can see that all the SVGs are used to create Items. My guess is that this second context was overlooked when the initial issue was created.