search

fritzmg / contao-sharebuttons

Simple extension to provide share buttons as a module and content element in Contao
GNU Lesser General Public License v3.0
18 stars 2 forks source link

Fontawesome 5 #52

Open operatorone opened 3 years ago

operatorone commented 3 years ago

What about an update or additional option for Fontawesome 5 Free/Brands?

The CSS classes i.e. just changed to <a class="facebook fab fa-facebook-f" href="...

fritzmg commented 3 years ago

My plan is to actually ditch these fontawesome templates in the next major version and use inline SVGs instead, which you can then style directly.

operatorone commented 3 years ago

That's an excellent idea, which is good for the performance. Also, various icon sets with different colors, or can the icon be altered directly using CSS?

fritzmg commented 3 years ago

You can change colours for individual SVG components via your own CSS when using inline SVG, yes.

operatorone commented 3 years ago

Will it be delivered with inline SVG by default or has it to replace the used SVG file?

fritzmg commented 3 years ago

My plan is to provide inline SVGs by default, e.g. from https://feathericons.com/

operatorone commented 3 years ago

Very good idea. I‘m looking forward to the new version.