search

froala / KMSFroalaEditorBundle

Symfony bundle for Froala WYSIWYG HTML Rich Text Editor.
https://froala.com/wysiwyg-editor
105 stars 33 forks source link

[WIP] escape form options/variables with froala namespace #117

Closed mpoiriert closed 3 years ago

mpoiriert commented 4 years ago

This will show how this fix will be done.

There is a discrepancy with coding standard since my computer is set up for Symfony CS and the repository is now following it (big one is tab -> space).

I have test it (without any configured) and it's working so far.

jmsche commented 3 years ago

@sguionni @mpoiriert AFAICT this would require a major release? I think this is included in the last patch release

jmsche commented 3 years ago

@sguionni As expected this PR is a huge BC break... Updating from 3.1.0 to 3.1.1 is throwing errors as the option names have changed.

Could you please revert this commit, create a new patch release (3.1.2) and drop the current one (3.1.1) from Github & Packagist?

If you do so, I'll try to come up with code style & static analysis this week so a new major version could be released, along with @mpoiriert's changes to move the options "namespace".

sguionni commented 3 years ago

Revert the 2 commits from this PR?

jmsche commented 3 years ago

Yes

sguionni commented 3 years ago

It's done

jmsche commented 3 years ago

Thank you :) I'll start to work on it right away

jmsche commented 3 years ago

~Could also please remove v3.2.0 branch, and create a v3 branch from master? So when merging the upcoming PR(s) in master it won't mess with it~

Nevermind, this should be done after the upcoming CHANGELOG PR

sguionni commented 3 years ago

Ops, just did it

jmsche commented 3 years ago

Not a problem, see comment in #120