search

froala / KMSFroalaEditorBundle

Symfony bundle for Froala WYSIWYG HTML Rich Text Editor.
https://froala.com/wysiwyg-editor
105 stars 33 forks source link

Why tag 4.0.0? #126

Open jmsche opened 3 years ago

jmsche commented 3 years ago

Hi,

I'm wondering why version 4.0.0 has been tagged with this change? https://github.com/froala/KMSFroalaEditorBundle/commit/7e6856fcaf2b14933ad66e49a6e62562bd7e735e

The version number in the command is only an example, not the real value which will be pulled.

Can this tag/release be reverted please? And removed from packagist as well?

sguionni commented 3 years ago

@kapil2704 ??

jmsche commented 3 years ago

Hi @kapil2704, could you please stop committing tag change in the command & releasing please?

It does not make any sense to do that.

sguionni commented 3 years ago

@jmsche i have lost my access to this repository, i don't know what is happening with Froala, but i think you can create a new repository and abandon this one since @kapil2704 don't care about what we are saying

jmsche commented 3 years ago

Thanks for your answer @sguionni, didn't know that. That's unfortunate :/

I'll send an email to Froala support, and fork if no correct actions will be made.

jroszkiewicz commented 2 years ago

Thanks for your answer @sguionni, didn't know that. That's unfortunate :/

I'll send an email to Froala support, and fork if no correct actions will be made.

And how situation?

jmsche commented 2 years ago

I've sent a bunch of emails.

IIRC they removed the rights to @kapil2704, but I didn't manage to make them understand why I wanted to drop the commits on Github, & tags/releases on Packagist/Github. Problem is, I was never in direct contact with a technical employee, only sales employee.

As Symfony 6 is around the corner (planned for end of November) I think I'll fork the package & clean it up a bit, then make it compatible with Symfony 6.

I'll keep you posted on this issue.

jroszkiewicz commented 2 years ago

I've sent a bunch of emails.

IIRC they removed the rights to @kapil2704, but I didn't manage to make them understand why I wanted to drop the commits on Github, & tags/releases on Packagist/Github. Problem is, I was never in direct contact with a technical employee, only sales employee.

As Symfony 6 is around the corner (planned for end of November) I think I'll fork the package & clean it up a bit, then make it compatible with Symfony 6.

I'll keep you posted on this issue.

OK, thanks. You have my axe :)

jmsche commented 2 years ago

Hi again,

Here is the fork: https://github.com/leapt/froala-editor-bundle

It requires PHP 8.0+ & Symfony 5.3+. All tags have been reset so the bundle starts at v1 :)

Note that a Flex recipe is on its way as well: https://github.com/symfony/recipes-contrib/pull/1302