froala / wysiwyg-editor

The next generation Javascript WYSIWYG HTML Editor.
https://www.froala.com/wysiwyg-editor
Other
5.28k stars 673 forks source link

Inserting link fails when linkText is set to false #3611

Open tpetry opened 5 years ago

tpetry commented 5 years ago
Expected behavior.

When selecting a text inside froala, clicking the link toolbar button, typing an url and hitting save the text should be converted to an url.

Actual behavior.

A js error is thrown:

VM20 froala_editor.pkgd.min.js:7 Uncaught TypeError: Cannot read property 'value' of undefined
    at b.val (VM20 froala_editor.pkgd.min.js:7)
    at Object.E [as insertCallback] (VM20 froala_editor.pkgd.min.js:7)
    at E.Bootstrap.callback (VM20 froala_editor.pkgd.min.js:7)
    at Object.n [as exec] (VM20 froala_editor.pkgd.min.js:7)
    at o (VM20 froala_editor.pkgd.min.js:7)
    at r (VM20 froala_editor.pkgd.min.js:7)
    at t (VM20 froala_editor.pkgd.min.js:7)
    at E.Bootstrap.c (VM20 froala_editor.pkgd.min.js:7)
    at a (VM20 froala_editor.pkgd.min.js:7)
    at HTMLButtonElement.<anonymous> (VM20 froala_editor.pkgd.min.js:7)
Steps to reproduce the problem.
Versions
danielcrabtree commented 5 years ago

I have also encountered this bug in 3.0.5 on Win 10 with Firefox 69.

When linkText = false, links cannot be inserted and a javascript error appears in console.