search

froala / wysiwyg-editor

The next generation Javascript WYSIWYG HTML Editor.
https://www.froala.com/wysiwyg-editor
Other
5.28k stars 673 forks source link

Table editor doesn't show when the table is inside another tag. #4155

Closed abram27 closed 2 years ago

abram27 commented 3 years ago
Expected behavior.

Editor popup should show when table is inside another tag: Editor

Actual behavior.

When add div tag around table, the popup to edit the table does not show.

Steps to reproduce the problem.
  1. Go to https://froala.com/wysiwyg-editor/examples/resize-table/
  2. In code view add div tag around table
  3. In standard view click on table cell
  4. Editor for table doesn't display
Editor version.

3.2.3

OS.

Windows 10 19042.746

Browser.

Chrome 88.0.4324.104

Recording.

https://user-images.githubusercontent.com/17630795/106045076-26fec300-60a6-11eb-83ac-d5505f2d4641.mp4

earshinov commented 3 years ago

The stack trace (from #4198):

Uncaught TypeError: Cannot read property 'length' of undefined
    at _currentSelection (table.js?version=1.0.1:1715)
    at _selectionOffset (table.js?version=1.0.1:1817)
    at _showEditPopup (table.js?version=1.0.1:92)
    at HTMLTableCellElement._mouseUp (table.js?version=1.0.1:2030)
    at froala_editor.pkgd.min.js?version=1.0.1:7
kaniansky commented 3 years ago

why would a new bug be fixed only in 4th upcoming minor version?

funnelitadmin commented 3 years ago

i am also facing same issue in angular 11

HiHub-Online commented 3 years ago

In v3.2.4 to table (in another tag) popup shows correct. But for all versions after no shown.

shnigi commented 3 years ago

Editing text after adding image is broken in 3.2.0 so I updated to 3.2.6 and can confirm I have the same problem in 3.2.6. Now downgraded to 3.2.4 and images + tables seem to work fine.

earshinov commented 3 years ago

I don't see anything related in the changelog for recently released v3.2.7 (https://github.com/froala/wysiwyg-editor/releases/tag/v3.2.7). Still waiting...

MeghashreeAP commented 2 years ago

Thanks for your feedback. This issue is not reproducible or have been found to be fixed on the latest Froala release v4.0.8. Can you please upgrade and check?

earshinov commented 2 years ago

I can confirm that this issue is fixed in 4.0.9

ilyaskarim commented 2 years ago

Issue is being fixed