search

frodeborli / serializor

PHP Serializor will serialize almost anything in PHP, including closures and anonymous classes.
MIT License
14 stars 2 forks source link

General discussion #8

Open oruborus opened 3 weeks ago

oruborus commented 3 weeks ago

First and foremost: Thank you for your work, @frodeborli! I was working on a similar library for the last days but your work is great so i'd like to contribute here.

As I am reading through your code some questions arise. Maybe you could answer them here as they come up.

  1. Why the support for PHP 7.3 and up?
frodeborli commented 3 weeks ago

Does it work with 7.3? For me 8.1 is most important. Where did I say 7.3? It may have been a goal to align with some other serialization library, come to think of it.

frodeborli commented 3 weeks ago

I really do appreciate contributions. This is a type of library that is difficult to make, but when you need it it is really useful, so its nice with some assistance in building it.

oruborus commented 3 weeks ago

Does it work with 7.3? For me 8.1 is most important. Where did I say 7.3? It may have been a goal to align with some other serialization library, come to think of it.

https://github.com/frodeborli/serializor/blob/6df7a36ef487a6dccecd702a0c2337d425851c1c/composer.json#L36

I think supporting ^8.1 should be enough. A lot of tests will break on 7.3-8.0 as there is no readonly...