frondeus / fvtt-syrin-control

Syrinscape Online Control plugin for FoundryVTT
MIT License
15 stars 5 forks source link

0.3.0 Able to play one-shots but not select Soundsets #35

Closed drober76 closed 2 years ago

drober76 commented 2 years ago

Describe the bug Using module 0.3.0, Foundry v9 on Forge in Chrome on Mac, the Soundset pull-down shows all available soundsets, but when a soundset is selected, the drop down closes and returns to the default "-no soundset-" selection. Moods remain unselectable.

Global one-shots load in the Ambient Sound browser and can be played, so API key appears to be functioning.

Details

frondeus commented 2 years ago

Can you select a soundset/mood in the playlist? Is it only related to scene config?

Anyway: That sounds not right. Definitely. Could you send me what the logs say?

DrWiFi commented 2 years ago

Hello, I am having the same issue. This is in the main sound tab, though the scene ambiance dialog box acts the same. I tried downloading Firefox and it appears to work as intended, however Chrome behaves as described above. I can start / stop a previously saved playlist and the global oneshots. There is no entry in the dev tools when I select the drop down item.

frondeus commented 2 years ago

Hi, thanks for extra details. I will look into it soon.

decron82 commented 2 years ago

I am also seeing this issue running on forge-vtt.com. If I can help please let me know.

RyanD commented 2 years ago

I am having same issue.. if its related I am using their subscription package so my soundset options are huge

RyanD commented 2 years ago

I am using Foundry app btw

frondeus commented 2 years ago

Okay, sorry for the long waiting time.

Lets make a summary of #35, #38 and #42. It seems to me that there is one bug occurring on Chrome/Chromium/Edge (edge is using chrome engine so it makes sense), and also probably only on macOS.

The problem is, I am unable to replicate the bug, however, I'm using Linux & Windows only. First of all I am going to close other issues and keep this one only.

frondeus commented 2 years ago

When you select a soundset, the SyrinControl sends a request to SyrinscapeAPI asking what moods are part of the set. While waiting for the response, it blocks mood selection since it might be updated at any second. Then it seems that the response never arrives, or it's invalid, or there is another nasty bug causing it to enter the invalid state. Because of that, it never enables the dropdown again.

That's all that I know. I would have to know what the response was (if there was any response). I'm sure your API keys are correct since you were able to retrieve a list of soundsets. That's something. But I'm not sure why, oh why another request is causing problems only on Chrome.

frondeus commented 2 years ago

On my Chrome it looks like this:

Screenshot from 2022-08-08 22-36-16

I am getting response for the request called ?soundset__id=... and the status is as expected: 200

frondeus commented 2 years ago

I released https://github.com/frondeus/fvtt-syrin-control/releases/tag/0.3.1-alpha1-3 Could someone install it manually (not via ForgeVTT and not via Foundry update mechanism, just Drag n Drop into the foundry modules dir) and see if there are more logs? And paste them here :)?

It should look like this:

Screenshot from 2022-08-09 22-38-00

frondeus commented 2 years ago

This link also should work if you want to install it via Foundry or Forge manager: https://github.com/frondeus/fvtt-syrin-control/releases/download/0.3.1-alpha1-3/module.json

frondeus commented 2 years ago

I just released version 0.3.1 it should fix the issue.