search

frostney / react-native-create-library

:notebook: Command line tool to create a React Native library with a single command
MIT License
1.45k stars 113 forks source link

react-native-create-library command does not create a MainActivity.java #88

Closed jerinho closed 5 years ago

jerinho commented 5 years ago

react-native-create-library command does not created MainActivity.java file. Only ...Module.java and ...Package.java created. And also an empty AndroidManifest.xml

Why?

maicki commented 5 years ago

Hey, did you create the library from master? The version on npm unfortunately is really outdated: #78

jerinho commented 5 years ago

created it directly from command. here some details

maicki commented 5 years ago

Try out creating it from master. As said above the npm version is pretty old, unfortunately I don't have the permissions to push a new version.

jerinho commented 5 years ago

ok. now i'm understand. we need to create a react-native app first using react-native init before react-native-create-library. they should fix the documentation

jerinho commented 5 years ago

Hey, did you create the library from master? The version on npm unfortunately is really outdated: #78

how do you know i used npm?. because i'm pretty sure i used yarn

maicki commented 5 years ago

What I meant is if you installed react-native-create-library from the npm registry. yarn uses the npm registry to install packages.

jerinho commented 5 years ago

ok. now i'm understand. we need to create a react-native app first using react-native init before react-native-create-library. they should fix the documentation

unfortunately this not working either. it asking for gradle-wrappers version of 2.2 and revert build tools version from latest one to the oldest one possible. if i change it back manually the compilation fail saying com.reactlibrary.MyActivity not found

jerinho commented 5 years ago

Try out creating it from master. As said above the npm version is pretty old, unfortunately I don't have the permissions to push a new version.

i guess it's from master npm i -g git+https://github.com/frostney/react-native-create-library.git

jerinho commented 5 years ago

i close this issue as it's a misunderstanding. i suggest you to edit the instruction of how to use this repo. i've wrote some steps to follow in issue #89

thank you for all your responses 😺