search

frostney / react-native-ibeacon

:satellite: iBeacon support for React Native
MIT License
375 stars 54 forks source link

Update imports to use namespaces to be compatible with rn@0.40.0 #43

Closed peterjuras closed 5 years ago

peterjuras commented 7 years ago

Fixes #42

frostney commented 7 years ago

Thank you. This is amazing! 👍 Let me just quickly test this for myself, because I don't believe I have any RN 0.40 projects yet.

peterjuras commented 7 years ago

Did you find time to test the PR yet?

frostney commented 7 years ago

I would prefer not to break backwards compatibility if we could avoid it. Would it be possible to update this PR to cater for this @peterjuras ? I found a sensible approach to this here: https://medium.com/@thisismissem/how-to-upgrade-react-native-modules-in-a-backwards-compatible-manner-a5b5c48d590c#.ku4y0zjq3 What's your opinion on this?

peterjuras commented 7 years ago

Personally, I don't think it is worth it to hold up backwards compatibility, since react-native is still not out of beta and changing quickly.

Also, it appears that almost no react-native library has chosen to go with this path (I only saw Microsoft's code-push do these sorts of imports), therefore a lot of projects have to migrate anyways because big libraries (e.g. react-native-vector-icons, facebook's own react-native-fbsdk) did not migrate in a backwards compatible way.

However, this is your repo, therefore I leave the choice up to you. I created an alternative pull request that imports the header with the way you described and it works for both 0.40 and 0.39. I don't recommend it though.

Feel free to choose any of the approaches.

peterjuras commented 7 years ago

Any update on the merging of a PR alternative?

plbrault commented 7 years ago

@frostney Any update?

cahalane commented 7 years ago

Please merge one of the options available! The iOS side of my app is being stalled by this.

PeterKow commented 7 years ago

Yes can we merge this? We are using it in our app with NR 42.3 and with those changes everything works nicely :) 👍

leesolway commented 7 years ago

Any news on this being merged?

peterjuras commented 7 years ago

I've since moved to react-native-beacons-manager. It has a similar (or pretty much the same API) and works under iOS and Android with newer react-native versions.

I feel bad for "advertising" an alternative, but this might at least be something worthwhile to check out while this is being updated ...

peterjuras commented 5 years ago

Closed due to inactivity of repository.