search

fruitcake / laravel-cors

Adds CORS (Cross-Origin Resource Sharing) headers support in your Laravel application
MIT License
6.27k stars 613 forks source link

Enable PHP 8 builds #511

Closed driesvints closed 3 years ago

driesvints commented 4 years ago

PHP 8 is almost upon us so we should make sure laravel-cors runs properly on it in Github Actions.

In draft until https://github.com/asm89/stack-cors/pull/83 is merged.

barryvdh commented 4 years ago

I've tagged stack-cors, so converted this PR to ready for review + rerun tests. Might take a few minutes for the tag to be found though.

driesvints commented 4 years ago

I can't seem to retrigger the builds myself for some reason..

barryvdh commented 4 years ago

Oh phpunit is the culprit. Might need to update that.

barryvdh commented 4 years ago

Hmm https://github.com/laravel/dusk is not yet PHP8 compatible?

driesvints commented 4 years ago

@barryvdh trying to get that fixed in a few. Gonna concentrate on the skeleton atm first 👍

barryvdh commented 3 years ago

Seems to be passing now, thanks!