search

fruxefarms / FruxePi

Indoor farming software using the Raspberry Pi
https://docs.fruxe.co
Other
142 stars 41 forks source link

Camera Button Disappears after adding User #49

Closed dcaud closed 5 years ago

dcaud commented 5 years ago

After 0.3 update I saw the new camera button. And it worked beautifully. Then, I added a new user — with an email address as a username and a password. The camera button was then not present. Can you replicate that issue?

fruxefarms commented 5 years ago

That is very strange. I followed the procedure several times and no success replicating the issue. It is very puzzling because the only logic attached to that button is whether the camera is activated or not. An overlap seems very strange. However I did find one small bug in this release that I have fixed and will push out later today. Perhaps after that fix on a new install all will be well.

dcaud commented 5 years ago

I think I've figured out the problem. It does NOT have to do with adding a user...as I said previously. Sorry for that wild goose chase.

The view button disappears if you delete the default crop. This is happening because the button is inside the Crops Carousel!

fruxefarms commented 5 years ago

Ah yes, that makes sense. That is the way it is supposed to work (whether helpful or not). Adding any crop back and the button will return. However, now I'm thinking that should be changed to display regardless of the crop.

dcaud commented 5 years ago

Now that I understand how it works, I can keep a crop. It looks a little odd because I don't use the crop feature so I have a crop names "_" with a set of random dates and such.

No big deal, but would it be easy (and a good idea) to move it to the space above...in the banner area or somewhere else?

On Mon, Apr 29, 2019 at 4:03 PM FruxePi notifications@github.com wrote:

Ah yes, that makes sense. That is the way it is supposed to work (whether helpful or not). Adding any crop back and the button will return. However, now I'm thinking that should be changed to display regardless of the crop.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fruxefarms/FruxePi/issues/49#issuecomment-487722978, or mute the thread https://github.com/notifications/unsubscribe-auth/AG2WKFBSPO2QM3SJMPXKXHDPS5IB7ANCNFSM4HI7XGCQ .

fruxefarms commented 5 years ago

I think that's entirely reasonable to have the camera separate. It shouldn't be dependent on the crop (and who says the Crop feature is even useful for some). Great feedback!

fruxefarms commented 5 years ago

In the latest commit I changed the code to display the button without a crop being present.

dcaud commented 5 years ago

Excellent. Works like a charm!

On Mon, Apr 29, 2019 at 6:18 PM FruxePi notifications@github.com wrote:

Closed #49 https://github.com/fruxefarms/FruxePi/issues/49.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fruxefarms/FruxePi/issues/49#event-2308053764, or mute the thread https://github.com/notifications/unsubscribe-auth/AG2WKFGC57NDC2LP6SN4GIDPS5XZXANCNFSM4HI7XGCQ .