search

fschulze / sqlalchemy_schemadisplay

Other
143 stars 37 forks source link

Add Python 3 to test matrix #29

Closed abitrolly closed 2 years ago

abitrolly commented 2 years ago

This removes Python matrix from actions workflow, because tested Python versions are configured in tox.ini.

fschulze commented 2 years ago

I like to keep the matrix as it is easier to see which version fails. You might want to add the explicit environment instead, see: https://github.com/devpi/devpi/blob/main/.github/workflows/main.yml#L61 https://github.com/devpi/devpi/blob/main/.github/workflows/main.yml#L85

abitrolly commented 2 years ago

I added Python 3.10 to the tox matrix and now tests fail. I am adding GitHub Action environment for selecting Python for tox.

abitrolly commented 2 years ago

Added tox + GitHub Actions matrix. Now need to fix the tests.

nhoening commented 2 years ago

14 might have some useful things to work from. I only had one problem with that work, see comments.

abitrolly commented 2 years ago

All Python 3 tests fixed. @fschulze this is ready for review.