search

fsprojects / DynamoDb.SQL

SQL-like external DSL for querying and scanning Amazon DynamoDB
http://fsprojects.github.io/DynamoDb.SQL
MIT License
54 stars 9 forks source link

ILMerge dependencies into assembly #8

Closed dfevre closed 10 years ago

dfevre commented 10 years ago

It would be good if you could use ILMerge to merge the dependencies into the DynamoDB.SQL assembly. That way, we could use any version of AWSSDK.dll along side with any version of DynamoDB.SQL.

theburningmonk commented 10 years ago

Sure I'll have a look at doing that, vaguely remember looking into this before and decided I couldn't do it at the time, let me get back to you on that.

theburningmonk commented 10 years ago

Based on conversation with Björn Rochel and Steffen Forkmann, it would seem you won't be able to use the AWSSDK from nuget and the version merged with DynamoDB.SQL side by side without having type conflicts.

ilmerge-convo

theburningmonk commented 10 years ago

If anyone can find a better way, please me know, but for now we'll have to stick with using binding redicts, sadly.

dfevre commented 10 years ago

Thanks for that. I had a go at this myself after raising this issue and found similar problems. It seems to be OK if the merged assembly is used entirely internally and isn't exposed as a part of your interface but it doesn't work if, for example, you need the caller to pass in an AmazonDynamoDBClient as a parameter to something. In that case the AmazonDynamoDBClient class from the merged assembly will be considered to be a different type to the one in the AWSSDK assembly - they'll be 2 different types with the same name.

Thanks again for looking into this.

theburningmonk commented 10 years ago

I see, that's consistent with what the others are saying, it's a shame ILMerge's not an option. Sorry it took me a while to get around to this, let me know if you found any other issues or have some suggestions for improvement.