fsprojects / ExcelFinancialFunctions

.NET Standard library providing the full set of financial functions from Excel.
https://fsprojects.github.io/ExcelFinancialFunctions
Other
194 stars 66 forks source link

fix yield for the last period before maturity #11

Closed cpell closed 8 years ago

cpell commented 8 years ago

This fix works. Could it be merged into the master branch?

luajalla commented 8 years ago

Thank you! I couldn't test it propertly without Excel... nice to know it works.

cpell commented 8 years ago

Ah, I see. I tried to test it previously but didn't realize it wasn't in the master branch so the builds I was testing did not actually have the fix. Thanks!

I can provide more test cases for the coupnum < 1 if you'd like but I do not see a test file for the yield function.

dsyme commented 8 years ago

Hi @cpell - I was chatting with @luajalla and we wondered if you would like to be a co-maintainer on this repo? That would allow you to post updated Nuget packages as well. Please let us know what you think. We'd write up some dev notes on updating the packages

Cheers! don

cpell commented 8 years ago

Hi @dsyme, Thanks for reaching out. I'm happy to help where I can with maintaining the repo. Chris

dsyme commented 8 years ago

@luajalla Could you please give @cpell:

Cheers! Don

luajalla commented 8 years ago

Hi @cpell, do you have a nuget account? if so, what is your user name there?

Thanks, Natallie

cpell commented 8 years ago

@luajalla Accepted invite and created nuget account as cpell.

luajalla commented 8 years ago

Thanks, done!