Build library as .NET Standard 2.1, tests as .NET Core 3.1 and NUnit 3

fsprojects / ExcelFinancialFunctions

.NET Standard library providing the full set of financial functions from Excel.

https://fsprojects.github.io/ExcelFinancialFunctions

Other

194 stars 66 forks source link

Build library as .NET Standard 2.1, tests as .NET Core 3.1 and NUnit 3 #28

Closed jcoliz closed 2 years ago

jcoliz commented 2 years ago

Hi, I converted the library and NUnit tests to .NET Core, please have a look. I'm building these using Azure Pipelines at https://jcoliz.visualstudio.com/ExcelFinancialFunctions/_build. The only real change I had to make is that the tests would not discover without the change to parseArray.

Haven't touched the Excel tests yet.

(Related to Issue #9)

dsyme commented 2 years ago

Hey that's great. Good job

Would you like to be co-maintainer on this repo?

jcoliz commented 2 years ago

Yah, I'm happy to help. This PR has literally the first line of F# I've ever written, but I do know .NET and Excel.

dsyme commented 2 years ago

@jcoliz Nice work! :)

I'll make you co-admin

dsyme commented 2 years ago

@jcoliz Any chance you could move CI to Github actions? That's what most of the projects in "fsprojects" use

jcoliz commented 2 years ago

Right, I'm happy to take a TODO on that. I used Azure Pipelines because it's what I know. I've been meaning to figure out Github actions.

dsyme commented 2 years ago

Cool thanks :)