search

fsprojects / FSharp.Control.Reactive

Extensions and wrappers for using Reactive Extensions (Rx) with F#.
http://fsprojects.github.io/FSharp.Control.Reactive
Other
284 stars 58 forks source link

nunit refactor to xunit. #118

Closed xp44mm closed 4 years ago

xp44mm commented 5 years ago

because xunit is my used lib, maybe some body else need it also.

xp44mm commented 5 years ago

just add file ObservableSpecs.xunit.fs. others no change.

stijnmoreels commented 5 years ago

I think you forgot to add the paket.references/paket.dependencies for xUnit? xUnit is also my preffered testing framework \w FsCheck; but should check with @panesofglass .

Also, if we would move the xUnit; I would make the change complete and also update all the other tests and migrate to xUnit.

xp44mm commented 5 years ago

i compile pass the tests in my separate project. but some functionality i can't make sense. and i can't find them in api doc. that is: open FSharp.Control.Reactive.Testing.Marbles Observable.switchMap Observable.exhaustMap Observable.catchOption Observable.catchResult Observable.consumeMap Observable.consumeNextOn Observable.serve so. i comment them out with whole Fact it belong. let tests pass.

xp44mm commented 5 years ago

i have converted all test files. and run the tests is correctly.

panesofglass commented 5 years ago

I'm fine switching to xUnit. Do we know why the builds are failing?

panesofglass commented 5 years ago

Looks like the builds fail due to incorrect dependency listings: Package FsCheck.Xunit was not found in group Main of the paket.lock file.