search

fsprojects / FSharp.Control.Reactive

Extensions and wrappers for using Reactive Extensions (Rx) with F#.
http://fsprojects.github.io/FSharp.Control.Reactive
Other
284 stars 58 forks source link

Fix issue 115 #128

Closed panesofglass closed 4 years ago

panesofglass commented 4 years ago

Closes #115

panesofglass commented 4 years ago

I wonder why the build is now failing? Looks like failing tests, though they appear to succeed locally. Any ideas?

PhilT commented 4 years ago

I wonder why the build is now failing? Looks like failing tests, though they appear to succeed locally. Any ideas?

Well if you click on the link to the Travis build, it doesn't seem to support .NET core 3.1 yet.

As for AppVeyor the error is a little more cryptic:

C:\Users\appveyor\AppData\Local\Microsoft\dotnet\sdk\3.1.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(143,5): error NETSDK1085: The 'NoBuild' property was set to true but the 'Build' target was invoked. [C:\projects\fsharp-control-reactive\src\FSharp.Control.Reactive\FSharp.Control.Reactive.fsproj]
NETSdkError: C:\Users\appveyor\AppData\Local\Microsoft\dotnet\sdk\3.1.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(143,5): error NETSDK1085: The 'NoBuild' property was set to true but the 'Build' target was invoked.
panesofglass commented 4 years ago

The issue appears to be that the distro: trusty was EOL and no longer had updates for newer dotnet sdks. I switched to the default (xenial), and it seems to be running. Now I just have to work out this Build/NoBuild issue. Works locally, but fails on CI. I took out the NoBuild in the Pack task. Hopefully that will resolve this.