ftde0 / yt2009

2009 youtube frontend.
Apache License 2.0
193 stars 119 forks source link

Comments parser error #53

Closed beitanam closed 9 months ago

beitanam commented 9 months ago
[yt2009_error] comments parser error TypeError: Cannot read properties of undefined (reading 'forEach')
    at Object.comments_parser (G:\SRVDTA\yt2009-main\back\yt2009utils.js:73:50)
    at G:\SRVDTA\yt2009-main\back\yt2009html.js:2377:37
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[yt2009_error] comments parser error TypeError: Cannot read properties of undefined (reading 'forEach')
    at Object.comments_parser (G:\SRVDTA\yt2009-main\back\yt2009utils.js:73:50)
    at G:\SRVDTA\yt2009-main\back\yt2009html.js:2380:37
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[yt2009_error] comments parser error TypeError: Cannot read properties of undefined (reading 'forEach')
    at Object.comments_parser (G:\SRVDTA\yt2009-main\back\yt2009utils.js:73:50)
    at G:\SRVDTA\yt2009-main\back\yt2009html.js:2377:37
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[yt2009_error] comments parser error TypeError: Cannot read properties of undefined (reading 'forEach')
    at Object.comments_parser (G:\SRVDTA\yt2009-main\back\yt2009utils.js:73:50)
    at G:\SRVDTA\yt2009-main\back\yt2009html.js:2380:37
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[yt2009_error] comments parser error TypeError: Cannot read properties of undefined (reading 'commentRenderer')
    at parseITComment (G:\SRVDTA\yt2009-main\back\yt2009utils.js:101:61)
    at G:\SRVDTA\yt2009-main\back\yt2009utils.js:85:25
    at Array.forEach (<anonymous>)
    at G:\SRVDTA\yt2009-main\back\yt2009utils.js:84:34
    at Array.forEach (<anonymous>)
    at Object.comments_parser (G:\SRVDTA\yt2009-main\back\yt2009utils.js:73:50)
    at G:\SRVDTA\yt2009-main\back\yt2009html.js:2377:37
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[yt2009_error] comments parser error TypeError: Cannot read properties of undefined (reading 'commentRenderer')
    at parseITComment (G:\SRVDTA\yt2009-main\back\yt2009utils.js:101:61)
    at G:\SRVDTA\yt2009-main\back\yt2009utils.js:85:25
    at Array.forEach (<anonymous>)
    at G:\SRVDTA\yt2009-main\back\yt2009utils.js:84:34
    at Array.forEach (<anonymous>)
    at Object.comments_parser (G:\SRVDTA\yt2009-main\back\yt2009utils.js:73:50)
    at G:\SRVDTA\yt2009-main\back\yt2009html.js:2380:37
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Happened after mobile loaded the recommendations, version 2.0.26.

beitanam commented 9 months ago

Came across this as well:

TypeError: Cannot read properties of undefined (reading 'includes')
    at checkBaseline (G:\SRVDTA\yt2009-main\back\backend.js:1058:34)
    at G:\SRVDTA\yt2009-main\back\backend.js:1073:8
    at Layer.handle [as handle_request] (G:\SRVDTA\yt2009-main\node_modules\express\lib\router\layer.js:95:5)
    at next (G:\SRVDTA\yt2009-main\node_modules\express\lib\router\route.js:144:13)
    at Route.dispatch (G:\SRVDTA\yt2009-main\node_modules\express\lib\router\route.js:114:3)
    at Layer.handle [as handle_request] (G:\SRVDTA\yt2009-main\node_modules\express\lib\router\layer.js:95:5)
    at G:\SRVDTA\yt2009-main\node_modules\express\lib\router\index.js:284:15
    at Function.process_params (G:\SRVDTA\yt2009-main\node_modules\express\lib\router\index.js:346:12)
    at next (G:\SRVDTA\yt2009-main\node_modules\express\lib\router\index.js:280:10)
    at rawParser (G:\SRVDTA\yt2009-main\node_modules\body-parser\lib\types\raw.js:67:7)
baseline h264 req /channel_fh264_getvideo?v=ctvdxiPJKH4
TypeError: Cannot read properties of undefined (reading 'includes')
    at checkBaseline (G:\SRVDTA\yt2009-main\back\backend.js:1058:34)
    at G:\SRVDTA\yt2009-main\back\backend.js:1073:8
    at Layer.handle [as handle_request] (G:\SRVDTA\yt2009-main\node_modules\express\lib\router\layer.js:95:5)
    at next (G:\SRVDTA\yt2009-main\node_modules\express\lib\router\route.js:144:13)
    at Route.dispatch (G:\SRVDTA\yt2009-main\node_modules\express\lib\router\route.js:114:3)
    at Layer.handle [as handle_request] (G:\SRVDTA\yt2009-main\node_modules\express\lib\router\layer.js:95:5)
    at G:\SRVDTA\yt2009-main\node_modules\express\lib\router\index.js:284:15
    at Function.process_params (G:\SRVDTA\yt2009-main\node_modules\express\lib\router\index.js:346:12)
    at next (G:\SRVDTA\yt2009-main\node_modules\express\lib\router\index.js:280:10)
    at rawParser (G:\SRVDTA\yt2009-main\node_modules\body-parser\lib\types\raw.js:67:7)

On video id ctvdxiPJKH4, after clicking HQ on the app.

ftde0 commented 9 months ago

looks like you've got a commentViewModel experiment which isn't available to everyone yet (not to me) so i can't really test and fix. will do once i get it so i can properly do so.

ftde0 commented 9 months ago

the issue should be fixed with https://github.com/ftde0/yt2009/commit/0c9189951d4b3092a0196f51b464f123536165a8. please report back on whether it is. feel free to close if so.