search

ftlabs / fruitmachine

View rendering engine
MIT License
247 stars 18 forks source link

The npm module contains out-of-date files in build/ #83

Closed kornelski closed 9 years ago

kornelski commented 10 years ago

Change from #81 isn't usable, because build/fruitmachine.js is an older version than lib/fruitmachine.js.

matthew-andrews commented 10 years ago

Time to delete the built files?

kornelski commented 10 years ago

+1 for deletion (and since it may be a back-compat break, changing version to 1.0.0 as well?)

matthew-andrews commented 10 years ago

The only problem is bower - the plan was to fork all the deps from wilson's profile & merge in the bower.json compatibility pull requests ... Just haven't got round to it.

Alternatively, ditch bower support.

kornelski commented 10 years ago

I have no opinion on bower support. I just need the ft-app to stop flooding the error aggregator ;)

georgecrawford commented 10 years ago

Can't we update the built file to #81, which will fix the ft-app issue, and deal with removing the built file as a separate issue which doesn't block anything?

kornelski commented 10 years ago

+1 @georgecrawford

but I've noticed that it actually isn't the cause of the error I'm seeing in the app (I've misdiagnosed the issue).