search

fubaWoW / InstancePortalsAdv

GNU General Public License v3.0
0 stars 1 forks source link

Instance Portals Advanced showing in settings menu multiple times #5

Closed NoShotz closed 3 months ago

NoShotz commented 4 months ago

image

fubaWoW commented 4 months ago

hmm... What Version? Any Special Conditions? Did you try with just IPA enabled?

I've tested now multiple Times without any AddOns (except IPA and my Debug Addons) looks like this for me: image

and with ALL my 183 Addons active: image

NoShotz commented 4 months ago

The version is 110002.07-Release, so far it has only happened once, and I had all my various addons enabled, one thing to note, I didn't see any errors when this issue occurred.

fubaWoW commented 4 months ago

Does it still happen?

NoShotz commented 4 months ago

I just checked, and it has happened again, but I don't see any errors specifically mentioning this addon, one thing to note, it is on a character that hasn't had the latest version of the addon loaded before, could it potentially be related?

fubaWoW commented 4 months ago

No that should no matter because the Settings are Loaded from New every time you "Enter the World", then can be a Login or a Interface Reload.

But if there is some other Addon that trigger the "PLAYER_ENTERING_WORLD" event multiple times, this maybe can happen!

fubaWoW commented 4 months ago

i've pushed a new update 110002.08 this will prevent from creating Settings Multiple Times, even if the event PLAYER_ENTERING_WORLD is triggered multiple times

But i would suggest to check all your AddOns, because this is not a "default" that events like PLAYER_ENTERING_WORLD is triggered multiple times and this can cause major Performance issues in some cases!

Dathwada commented 4 months ago

It is normal that the PLAYER_ENTERING_WORLD event can be triggered multiple times.

"Fires when the player logs in, /reloads the UI or zones between map instances. Basically whenever the loading screen appears."

I testet this on verison 110002.07 and if you use some portals to travel and the loading screen appears there will be a new menu entry.

I guess you want to use the PLAYER_LOGIN event instead:

Triggered immediately before PLAYER_ENTERING_WORLD on login and UI Reload, but NOT when entering/leaving instances.

NoShotz commented 4 months ago

Makes sense, I was going through portals doing the pre-patch event.

fubaWoW commented 4 months ago

It is normal that the PLAYER_ENTERING_WORLD event can be triggered multiple times.

"Fires when the player logs in, /reloads the UI or zones between map instances. Basically whenever the loading screen appears."

I testet this on verison 110002.07 and if you use some portals to travel and the loading screen appears there will be a new menu entry.

I guess you want to use the PLAYER_LOGIN event instead:

Triggered immediately before PLAYER_ENTERING_WORLD on login and UI Reload, but NOT when entering/leaving instances.

well... you're totally right!

don't know why i did this mistake 🤷‍♂️

I know the PLAYER_LOGIN event and also everything else in the AddOn loading process, but... hey... stupid me! 🤦‍♂️ 🤣

i will update this later!

Thanks for the hint! 👌